You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Medium Risk
Touches core array decoding paths and changes getStringArray behavior for enum/string arrays, so regressions could affect query result parsing for array columns despite strong test coverage.
Overview
Adds getObjectArray(int|String) to the binary reader and GenericRecord, enabling Array columns of arbitrary element types (including nested/multidimensional and nullable arrays) to be retrieved as Object[] (with nested arrays recursively converted).
Updates getStringArray to return underlying String[] directly and to support Array(Enum*) by returning enum names; improves Javadoc/error messages, and wires the new API through AbstractBinaryFormatReader, MapBackedRecord, and BinaryReaderBackedRecord.
Adds extensive unit/integration coverage for getObjectArray across 1D/2D/3D arrays, empty arrays, nullable elements, and list-backed array decoding, plus a new BinaryReaderBackedRecordTest.
Written by Cursor Bugbot for commit 9d5d0f0. This will update automatically on new commits. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Summary
getObjectArrayto getObject[]Array(Tuple())Closes #2738
Docs: ClickHouse/clickhouse-docs#5551
Checklist
Delete items not relevant to your PR:
Note
Medium Risk
Touches core array decoding paths and changes
getStringArraybehavior for enum/string arrays, so regressions could affect query result parsing for array columns despite strong test coverage.Overview
Adds
getObjectArray(int|String)to the binary reader andGenericRecord, enabling Array columns of arbitrary element types (including nested/multidimensional and nullable arrays) to be retrieved asObject[](with nested arrays recursively converted).Updates
getStringArrayto return underlyingString[]directly and to supportArray(Enum*)by returning enum names; improves Javadoc/error messages, and wires the new API throughAbstractBinaryFormatReader,MapBackedRecord, andBinaryReaderBackedRecord.Adds extensive unit/integration coverage for
getObjectArrayacross 1D/2D/3D arrays, empty arrays, nullable elements, and list-backed array decoding, plus a newBinaryReaderBackedRecordTest.Written by Cursor Bugbot for commit 9d5d0f0. This will update automatically on new commits. Configure here.