Skip to content

Conversation

@namm2
Copy link

@namm2 namm2 commented Dec 29, 2025

Use secretKeyRef to not expose Clickhouse credentials into runtime environment

Signed-off-by: Nam Hai Nguyen <namhai.nguyen-ext@commercetools.com>
@CLAassistant
Copy link

CLAassistant commented Dec 29, 2025

CLA assistant check
All committers have signed the CLA.

Signed-off-by: Nam Hai Nguyen <namhai.nguyen-ext@commercetools.com>
@HamseTelia
Copy link

Could we also please add the clickhouse user's password to be referenced from a secret clickhouse.config.users.appUserPassword. Like suggested here: #125

clickhouse:
  config:
    users:
      # Existing inline password support (for backward compatibility)
      appUserPassword: "hyperdx"
      otelUserPassword: "otelcollectorpass"
      otelUserName: "otelcollector"
      
      # NEW: External secret support
      useExternalSecret: false
      externalSecret:
        name: ""
        appUserPasswordKey: "app-user-password"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants