fix: ignore unmapped PerformanceIssue events#1852
Merged
Lightning00Blade merged 1 commit intoChromeDevTools:mainfrom Apr 17, 2026
Merged
Conversation
Lightning00Blade
approved these changes
Apr 16, 2026
Collaborator
Lightning00Blade
left a comment
There was a problem hiding this comment.
Thanks for the PR,
I think we can merge after the rebase and update to tests.
And remove the the hard coded bit after we update the version of devtools.
Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>
7bbfcee to
9808763
Compare
Lightning00Blade
approved these changes
Apr 16, 2026
Merged
via the queue into
ChromeDevTools:main
with commit Apr 17, 2026
ea57e86
28 of 30 checks passed
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PerformanceIssueevents before passing them to the DevTools IssuesManager mapper, which currently has no handler for that issue codePerformanceIssueis ignored without collecting an issue or writing a console warningFixes #1850
Testing
npm run buildnpm run test:no-build -- tests/PageCollector.test.tsnpm run check-format