Skip to content

fix: ignore unmapped PerformanceIssue events#1852

Merged
Lightning00Blade merged 1 commit intoChromeDevTools:mainfrom
officialasishkumar:fix/performance-issue-warning
Apr 17, 2026
Merged

fix: ignore unmapped PerformanceIssue events#1852
Lightning00Blade merged 1 commit intoChromeDevTools:mainfrom
officialasishkumar:fix/performance-issue-warning

Conversation

@officialasishkumar
Copy link
Copy Markdown
Contributor

Summary

  • ignore Audits PerformanceIssue events before passing them to the DevTools IssuesManager mapper, which currently has no handler for that issue code
  • preserve the existing mapper/logging path for other issue codes
  • add regression coverage that PerformanceIssue is ignored without collecting an issue or writing a console warning

Fixes #1850

Testing

  • npm run build
  • npm run test:no-build -- tests/PageCollector.test.ts
  • npm run check-format

@OrKoN OrKoN requested a review from Lightning00Blade April 13, 2026 07:31
Copy link
Copy Markdown
Collaborator

@Lightning00Blade Lightning00Blade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR,

I think we can merge after the rebase and update to tests.
And remove the the hard coded bit after we update the version of devtools.

Comment thread src/PageCollector.ts
Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>
@officialasishkumar officialasishkumar force-pushed the fix/performance-issue-warning branch from 7bbfcee to 9808763 Compare April 16, 2026 14:29
@Lightning00Blade Lightning00Blade added this pull request to the merge queue Apr 17, 2026
Merged via the queue into ChromeDevTools:main with commit ea57e86 Apr 17, 2026
28 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unhandled Audits PerformanceIssue spams stderr: 'No handler registered for issue code PerformanceIssue'

2 participants