Skip to content

fix: block tool calls when a dialog is open#1842

Closed
zerone0x wants to merge 3 commits intoChromeDevTools:mainfrom
zerone0x:issue-hunter/dialog-guard
Closed

fix: block tool calls when a dialog is open#1842
zerone0x wants to merge 3 commits intoChromeDevTools:mainfrom
zerone0x:issue-hunter/dialog-guard

Conversation

@zerone0x
Copy link
Copy Markdown

Summary

  • block page-scoped tool calls when a browser dialog is open
  • instruct agents to call handle_dialog first

Testing

  • not run (not requested)

Fixes #1069

Comment thread README.md Outdated
> [!NOTE]
> The <code>autoConnect</code> option requires the user to start Chrome. If the user has multiple active profiles, the MCP server will connect to the default profile (as determined by Chrome). The MCP server has access to all open windows for the selected profile.
>
> [!NOTE]
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert unrelated changes.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay

@zerone0x
Copy link
Copy Markdown
Author

reverted the extra note block in README as requested. pushed in 72bc89d.

@Lightning00Blade
Copy link
Copy Markdown
Collaborator

Hello,

Thanks for the PR, but we would like a different implementation,
where we report back if a Dialog was open to LLM and let it handle itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dialog Handling is still not fixed

2 participants