feat: add set_extra_http_headers tool for Network.setExtraHTTPHeaders#1176
Open
pedrodurek wants to merge 2 commits intoChromeDevTools:mainfrom
Open
feat: add set_extra_http_headers tool for Network.setExtraHTTPHeaders#1176pedrodurek wants to merge 2 commits intoChromeDevTools:mainfrom
pedrodurek wants to merge 2 commits intoChromeDevTools:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
OrKoN
requested changes
Apr 2, 2026
Collaborator
There was a problem hiding this comment.
Thanks for the PR! I think we should align with the suggestion in this comment #1175 (comment) and add this to the emulation tool.
Address review feedback to extend the existing emulate tool instead of adding a standalone set_extra_http_headers tool. - Add extraHTTPHeaders param to emulate tool schema - Add handler logic in McpContext.emulate() - Preserve existing headers when param is omitted - Move tests from network.test.ts to emulation.test.ts - Revert network.ts and network.test.ts to main
Author
|
@OrKoN I moved the functionality to the emulation tool. Let me know if further adjustments are needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extend the existing
emulatetool with anextraHTTPHeadersparameter that calls Puppeteer'spage.setExtraHTTPHeaders()(which uses CDPNetwork.setExtraHTTPHeadersunder the hood).Closes #1175
Approach
Per feedback from @natorion, this integrates into the existing
emulatetool rather than adding a standalone tool. Theemulatetool is already the central hub for page-level state modifications (userAgent, viewport, networkConditions, geolocation, colorScheme), and custom HTTP headers fit naturally alongside them. This also avoids increasing the MCP tool count and LLM token overhead.Changes
src/types.ts— AddedextraHTTPHeaders?: Record<string, string>toEmulationSettingssrc/tools/emulation.ts— AddedextraHTTPHeadersas an optional zod parameter on theemulatetoolsrc/McpContext.ts— Added handler logic in theemulate()method:page.setExtraHTTPHeaders()whenextraHTTPHeadersis provided{}is passedemulate({colorScheme: "dark"})from accidentally clearing previously-set headerstests/tools/emulation.test.ts— Added 5 test cases:{}Use Case
This enables setting custom HTTP headers on all requests — including the initial document navigation and
<script>tag loads — whichinitScriptcannot do since it runs after the document is already fetched.Usage