Fix subject_regex to also match German "AW:" reply prefix#897
Open
kleinski wants to merge 1 commit intoCheckmk:masterfrom
Open
Fix subject_regex to also match German "AW:" reply prefix#897kleinski wants to merge 1 commit intoCheckmk:masterfrom
kleinski wants to merge 1 commit intoCheckmk:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The subject_regex function does not account for the German Outlook reply
prefix "AW:" (short for "Antwort:"), which is the German equivalent of
"RE:". The upstream version of this file already includes "aw:" in the
regex pattern, but the local version is missing it.
If a mail server or gateway prepends "AW:" to the subject of a loop mail,
the message will not be recognized as a valid roundtrip mail. This results
in the mail being treated as lost and a false CRITICAL alert being raised.
Fix
Add "aw: " as an alternative prefix to the subject regex, consistent with
the already handled "re: " and "wg: " prefixes.
Notes