Skip to content

fix: skip presence_penalty and frequency_penalty for Grok-3-mini and Grok-4 models #6749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
octo-patch wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −0
Open

fix: skip presence_penalty and frequency_penalty for Grok-3-mini and Grok-4 models #6749

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions app/client/platforms/xai.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,11 @@ export class XAIApi implements LLMApi {
},
};

// Grok-3-mini and Grok-4 models do not support presence_penalty and frequency_penalty
const isGrokMiniOrV4 =
/grok-3-mini/i.test(modelConfig.model) ||
/grok-4/i.test(modelConfig.model);

const requestPayload: RequestPayload = {
messages,
stream: options.config.stream,
Expand All @@ -86,6 +91,12 @@ export class XAIApi implements LLMApi {
top_p: modelConfig.top_p,
};

if (isGrokMiniOrV4) {
// These models do not accept presence_penalty / frequency_penalty
delete (requestPayload as any).presence_penalty;
delete (requestPayload as any).frequency_penalty;
}

console.log("[Request] xai payload: ", requestPayload);

const shouldStream = !!options.config.stream;
Expand Down