Allow 0 for retries and retryInterval for UpdateFirmware and GetDiagnostics #365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmluy
changed the title
Contributor
Author
|
@robert-s-ubi can you help review this PR? |
robert-s-ubi
approved these changes
Dec 4, 2025
Contributor
robert-s-ubi
left a comment
robert-s-ubi
left a comment
There was a problem hiding this comment.
Thank you very much for so diligently preparing this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows a value of 0 for retries and retryInterval, which is in UpdateFirmware and GetDiagnostics. Based on the errata, 0 should be a valid value.
Fixes #362.