refactor(napi_wrap): make user provide Ref#10
Merged
wemeetagain merged 1 commit intomainfrom Mar 24, 2026
Merged
Conversation
We still want the option of the user providing the `Ref` if they want to hold the reference to the created napi object. This is a fix for bls integration on lodestar suffering from a memory leak - because our usage of our bls bindings in lodestar-z involves us doing a `_ = Env.wrap`, we drop the reference to the napi object while increasing the refcount, which means our finalize calls from the v8 GC is never called.
wemeetagain
approved these changes
Mar 24, 2026
wemeetagain
changed the title
RefRef
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We still want the option of the user providing the
Refif they want tohold the reference to the created napi object.
This is a fix for bls integration on lodestar suffering from a memory leak - because our usage of our bls bindings in lodestar-z involves us doing a
_ = Env.wrap,we drop the reference to the napi object while increasing the refcount,
which means our finalize calls from the v8 GC is never called.