Open
Conversation
nulltea
requested changes
Jan 25, 2024
Comment on lines
91
to
94
| .as_ref() | ||
| .iter() | ||
| .map(|v| builder.main().load_witness(F::from(*v as u64))) | ||
| .collect_vec(); |
Member
There was a problem hiding this comment.
we have this in 5 or more places now (incl step circuit), might be worth putting this in a util method for this?
Contributor
Author
|
I've removed the patch to halo2curves in the PR as well :D |
nulltea
approved these changes
Mar 5, 2024
Member
nulltea
left a comment
There was a problem hiding this comment.
My point re. code repetition still stands. Otherwise LGMT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO:
[x] Clean up some duplicate code
[x] Consider removing some of the preprocessor tests which only test individual circuits
[x] Fix spec tests
This PR reduces the amount of advice cells being used. We merklize a whole beacon header in circuit when what we really want is just a merkle proof for a couple specific fields.
Before:
After: