Configuration and Documentation of the Buildmaster and Workers#1
Open
brhat wants to merge 13 commits intoCenterForSecureEnergyInformatics:masterfrom
Open
Configuration and Documentation of the Buildmaster and Workers#1brhat wants to merge 13 commits intoCenterForSecureEnergyInformatics:masterfrom
brhat wants to merge 13 commits intoCenterForSecureEnergyInformatics:masterfrom
Conversation
dustsigns
reviewed
Jul 21, 2020
dustsigns
reviewed
Jul 21, 2020
dustsigns
reviewed
Jul 21, 2020
dustsigns
reviewed
Jul 21, 2020
dustsigns
reviewed
Jul 21, 2020
dustsigns
reviewed
Jul 21, 2020
dustsigns
reviewed
Jul 21, 2020
dustsigns
reviewed
Jul 21, 2020
dustsigns
reviewed
Jul 21, 2020
dustsigns
reviewed
Jul 21, 2020
dustsigns
reviewed
Jul 21, 2020
dustsigns
reviewed
Jul 21, 2020
dustsigns
reviewed
Jul 21, 2020
dustsigns
reviewed
Jul 21, 2020
dustsigns
reviewed
Jul 21, 2020
dustsigns
reviewed
Jul 21, 2020
dustsigns
reviewed
Jul 21, 2020
dustsigns
reviewed
Jul 21, 2020
dustsigns
reviewed
Jul 21, 2020
dustsigns
reviewed
Jul 21, 2020
dustsigns
reviewed
Jul 21, 2020
| - NSSM - the Non-Sucking Service Manager (https://nssm.cc/) | ||
| - set a password for your user | ||
| ## Warning | ||
| Some problem prevents a tls connection between the buildbot-worker on windows and the reverse proxy (traefik) in front of the buildmaster. |
Collaborator
Author
There was a problem hiding this comment.
Unfortunately, i was not able to resolve this issue yet. Note, that both VMs (Buildbot server and Windows builder) share a subnet exclusively for this communication as a workaround.
dustsigns
reviewed
Jul 21, 2020
| - set a password for your user | ||
| ## Warning | ||
| Some problem prevents a tls connection between the buildbot-worker on windows and the reverse proxy (traefik) in front of the buildmaster. | ||
| Because of this, tls is deactivated! |
Collaborator
Author
There was a problem hiding this comment.
I agree. As mentioned I wasn't able to resolve this issue, yet.
dustsigns
reviewed
Jul 21, 2020
dustsigns
reviewed
Jul 21, 2020
dustsigns
reviewed
Jul 21, 2020
dustsigns
reviewed
Jul 21, 2020
dustsigns
requested changes
Jul 21, 2020
There was a problem hiding this comment.
Thanks for the pull request.
General remarks regarding the pull request:
- When merging (after approval), please use a squash merge (so that the individual commits are no longer visible)
General remarks regarding documentation:
- Please use URL formatting like DataCompressor
- Please format file names and code-like portions as
source code - Please fix casing of proper names and abbreviations, e.g., "TLS" instead of "tls", "Web" instead of "web" etc.
- Please fix casing at the beginning of sentences -- The first word of each sentence or item (in an itemization) should be upper case
- Please add proper links for references, e.g., in "see buildbot/README.md". This also applies to (sub) folders and other file and folder references
You can find more detailed remarks as single comments within this review of the pull request. Please reply to them and add a new commit to this pull request to update it.
dustsigns
requested changes
Aug 19, 2020
| default: | ||
| minVersion: "VersionTLS12" | ||
| sniStrict: true | ||
| cipherSuites: |
There was a problem hiding this comment.
This list is very short and specific. Could this be the reason for the TLS issues? Please check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes the configuration currently running on mendel.fh-salzburg.ac.at and the workers involved.
The current setup uses the forked repositories; the code in this pull request already uses the main ones.