Skip to content

[ENG-9708] osfmetrics minus es6#11746

Open
aaxelb wants to merge 7 commits into
CenterForOpenScience:feature/9691-osfmetrics-cleanup-drop-es6from
aaxelb:9708-osfmetrics-minus-es6
Open

[ENG-9708] osfmetrics minus es6#11746
aaxelb wants to merge 7 commits into
CenterForOpenScience:feature/9691-osfmetrics-cleanup-drop-es6from
aaxelb:9708-osfmetrics-minus-es6

Conversation

@aaxelb
Copy link
Copy Markdown
Collaborator

@aaxelb aaxelb commented May 19, 2026

Ticket

Purpose

remove all code using elasticsearch6 (now redundant after #11739 )

Changes

  • remove es6 from settings, ci, and local dev setup
  • remove es6 djelme classes from osf.metrics
  • remove code that saves osfmetrics records to es6
  • remove obsolete management commands:
    • migrate_osfmetrics_6to8
    • populate_impact_preprint_metrics
    • reindex_es6
  • split osf.metrics.es8_metrics into osf.metrics.events, osf.metrics.daily_reports, osf.metrics.monthly_reports, osf.metrics.fields
  • move utils from now-deleted osf.metrics.counted_usage into osf.metrics.utils
  • rename FooEs8 to simply Foo
  • improve "raw" metrics api:
    • pass client errors back to client (instead of 502)
    • remove /_/metrics/raw/ (instead use /_/metrics/raw-<djelme_backend_name>/ with backend name from settings)
  • rename pytest mark es_metrics to djelme_elasticsearch_backends
  • when gathering last month usage metadata, sum usage across all versions of a preprint
    • move versioned-osfid-formatting to GuidVersionsThrough.versioned_osfid(), for ease of reuse

Side Effects

QE Notes

CE Notes

Documentation

@aaxelb aaxelb marked this pull request as ready for review May 20, 2026 18:01
@aaxelb aaxelb requested a review from felliott May 20, 2026 18:51
Copy link
Copy Markdown
Member

@felliott felliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so much deletion, this is magnificent. APPROVE APPROVE APPROVE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants