Migrate Nessus to use cos-common library #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olehavramenko
force-pushed
the
feat/add-nessus
branch
2 times, most recently
from
0d0056f to
799e079
Compare
olehavramenko
force-pushed
the
feat/add-nessus
branch
from
799e079 to
9e6d6fd
Compare
mfraezz
requested changes
Feb 4, 2026
Member
There was a problem hiding this comment.
When we upgraded the cluster this is deployed in to k8s v1.33 last week, we ran into some compatibility issues relating to the older version of docker used in this chart with cgroupfs, containerd, overlay2, etc, as well as issues with newer versions of docker restricting traffic over HTTP.
I've left suggestions which should suffice to address these issues. Otherwise, LGTM 
| repository: docker | ||
| tag: 17.06-dind | ||
| pullPolicy: Always | ||
| tag: "17.06" |
Member
There was a problem hiding this comment.
Suggested change
| tag: "17.06" | |
| tag: "25.0.5" |
| image: "{{ .Values.main.dind.image.repository }}:{{ .Values.main.dind.image.tag }}" | ||
| imagePullPolicy: "{{ .Values.main.dind.image.pullPolicy }}" | ||
| args: | ||
| - --storage-driver=overlay |
Member
There was a problem hiding this comment.
Suggested change
| - --storage-driver=overlay | |
| - --storage-driver=overlay2 | |
| - --tls=false | |
| command: | |
| - docker-init | |
| - -- | |
| - dockerd | |
| - --host=unix:///var/run/docker.sock | |
| - --host=tcp://0.0.0.0:2375 | |
| - --storage-driver=overlay2 | |
| image:{{ .Values.main.dind.image.repository }}:{{ .Values.main.dind.image.tag }} |
| dind: | ||
| image: | ||
| repository: docker | ||
| tag: 17.06-dind |
Member
There was a problem hiding this comment.
Suggested change
| tag: 17.06-dind | |
| tag: 25.0.5-dind |
| appVersion: 7.1.2 | ||
| description: Nessus Vulnerability Scanner | ||
| type: application | ||
| version: 1.0.0 |
Member
There was a problem hiding this comment.
Suggested change
| version: 1.0.0 | |
| version: 1.0.0 | |
| kubeVersion: ">=1.33.0-0" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.