Migrate MFR to use cos-common library #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olehavramenko
force-pushed
the
feat/add-mfr
branch
from
24d447f to
f05f1a7
Compare
olehavramenko
force-pushed
the
feat/add-mfr
branch
from
fc17f6c to
520f2bb
Compare
mfraezz
requested changes
Feb 4, 2026
Member
mfraezz
left a comment
mfraezz
left a comment
There was a problem hiding this comment.
One small consistency issue, otherwise LGTM
| - name: {{ .Values.autoroll.name }} | ||
| image: {{ default "bitnami/kubectl:latest" .Values.autoroll.image | quote }} | ||
| imagePullPolicy: {{ .Values.image.pullPolicy }} | ||
| imagePullPolicy: {{ .Values.appImage.pullPolicy }} |
Member
There was a problem hiding this comment.
appImage doesn't appear to be specified in values, hence below:
| startingDeadlineSeconds: 900 | ||
| activeDeadlineSeconds: 14400 | ||
| nodeSelector: {} | ||
| image: bitnami/kubectl:latest |
Member
There was a problem hiding this comment.
I might suggest changing this to default to
autoroll:
#...
image:
repo: bitnami/kubectl
tag: latest
pullPolicy: IfNotPresent
And updating these templated values in autoroll-cron.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.