Migrate share to use cos-common library#100
Open
olehavramenko wants to merge 1 commit intoCenterForOpenScience:masterfrom
Open
Migrate share to use cos-common library#100olehavramenko wants to merge 1 commit intoCenterForOpenScience:masterfrom
olehavramenko wants to merge 1 commit intoCenterForOpenScience:masterfrom
Conversation
olehavramenko
force-pushed
the
feat/add-share
branch
from
fd7d741 to
1bb6695
Compare
olehavramenko
force-pushed
the
feat/add-share
branch
from
70ffcd6 to
5b37f5f
Compare
mfraezz
reviewed
Feb 4, 2026
Member
mfraezz
left a comment
mfraezz
left a comment
There was a problem hiding this comment.
A few drive-by comments, waiting to do a full pass until our sync tomorrow, as you mentioned having some questions.
| ## ------- Postgresql | ||
| postgresql: | ||
| enabled: true | ||
| enabled: true # if you enable, please remember to look up in the values file other components: "If Postgres enabled" |
Member
There was a problem hiding this comment.
Prefer to default to false. Both existing SHARE deploys talk to a DB deployed elsewhere. This dependency could be removed.
Suggested change
| enabled: true # if you enable, please remember to look up in the values file other components: "If Postgres enabled" | |
| enabled: false # if you enable, please remember to look up in the values file other components: "If Postgres enabled" |
| ## ------- Rabbitmq | ||
| rabbitmq: | ||
| enabled: true | ||
| enabled: true # if you enable, please remember to look up in the values file other components: "If RabbitMq enabled" |
Member
There was a problem hiding this comment.
Prefer to default to false. Both existing SHARE deploys talk to a rabbit deployed separately. This dependency could be removed.
Suggested change
| enabled: true # if you enable, please remember to look up in the values file other components: "If RabbitMq enabled" | |
| enabled: false # if you enable, please remember to look up in the values file other components: "If RabbitMq enabled" |
|
|
||
| ## ------- Elasticsearch | ||
| elasticsearch: | ||
| enabled: true |
Member
There was a problem hiding this comment.
Prefer to default to false. Both existing SHARE deploys talk to an elastic cluster deployed separately. This dependency could be removed.
Suggested change
| enabled: true | |
| enabled: false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.