[ENG-9835] Admin contributors getting errors while reviewing draft registrations #853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng if some APIs returns 403 (/children, /files, ...)
nsemets
approved these changes
Jan 15, 2026
brianjgeiger
merged commit abe5115
into
CenterForOpenScience:feature/pbs-25-24
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Users with administrative permissions on a draft registration cannot access or edit certain sections of the draft (e.g., Analyses section). Instead, they receive a “You Need Permission” error. This happens even when the user is an admin on both the project and the draft registration, and even when accessing the draft through My Registrations → Drafts, which should grant full access.
This issue is affecting multiple users across multiple draft registrations, and previous patterns we thought explained the issue (e.g., drafts created before a certain date, admin mismatch between project and registration) are no longer consistent.
Summary of Changes
avoid /request-access/ page redirection on /registries/drafts/* reviewing if some APIs returns 403 (/children, /files, ...)
Screenshot(s)
3820-de45-4c60-adcf-a6b0f8d7723d.1.mp4
Side Effects
Maybe it will be worth to get DB dump for some data to figure out why the issue might occur
https://openscience.atlassian.net/browse/ENG-9835?focusedCommentId=100691
QA Notes