-
Notifications
You must be signed in to change notification settings - Fork 4
NodeJS Express Cache Layer #225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
- Wrap cache.set(), cache.invalidate(), cache.clear() to broadcast to all PM2 instances - Listen for 'process:msg' events to sync cache operations across cluster - Syncs cache data (set), invalidations, and clears across all instances - No overhead in non-cluster mode (checks process.send) - Minimal overhead in cluster mode (~1-5ms per operation) - Test script updated to handle load-balanced environments
All tests passing
- Add console.log to track cache sync messages being sent/received - Fix test to use limit=1-100, skip=0-9 for better distribution - Will help diagnose why PM2 broadcast isn't working
- Removed PM2 IPC synchronization attempt (process.send only communicates with master, not other workers) - Cleaned up duplicate shebang and documentation - Documented actual PM2 cluster behavior: each instance maintains independent cache - Cache hit rates ~25% per instance in 4-worker cluster vs 100% in single instance - Noted options for production: Redis/Memcached, sticky sessions, or accept tradeoff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.