Merged
Conversation
ehddnr301
approved these changes
Apr 27, 2025
Collaborator
ehddnr301
left a comment
ehddnr301
left a comment
There was a problem hiding this comment.
👍 정상실행 확인했습니다. 기여해주신 코드가 정말 깔끔하고 한눈에 들어옵니다. 많이 배우겠습니다.
Contributor
Author
@ehddnr301 |
nonegom
approved these changes
Apr 28, 2025
Contributor
nonegom
left a comment
nonegom
left a comment
There was a problem hiding this comment.
👍함수마다 주석 설정 필요하다고 생각했는데~ 감사합니다!
| @click.option("-p", "--port", type=int, default=8501, help="Streamlit port") | ||
| def cli(ctx, datahub_server, run_streamlit, port): | ||
| # pylint: disable=redefined-outer-name | ||
| def cli( |
Contributor
There was a problem hiding this comment.
👍: cli함수로 설정 변경한 거 좋은 것 같습니다
Contributor
Author
|
@nonegom 확인했습니다 감사합니당~~! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣ Issue Number
📝 요약(Summary)
💬 To Reviewers (선택)
PR Checklist
reference) How to Code Review