Feature/10 보여주는 결과의 확장 필요성#55
Closed
anjaaaaeeeellll wants to merge 16 commits intomasterfrom
Hidden character warning
The head ref may contain hidden characters: "10-\ubcf4\uc5ec\uc8fc\ub294-\uacb0\uacfc\uc758-\ud655\uc7a5-\ud544\uc694\uc131"
Closed
Conversation
Closed
ehddnr301
reviewed
Apr 20, 2025
Collaborator
ehddnr301
left a comment
There was a problem hiding this comment.
👍 Output을 선택적으로 가져올수 있는 부분 너무 좋습니다!

❗코드에서 에러가 나서 다음과 같이 고치긴했는데 제 환경문제인가 싶어서요오! 한번 더 확인해주세요!
streamlit_app.py
from connect_db import ConnectDB
-> from llm_utils.connect_db import ConnectDBst.write("결과:", res["generated_query"].content)
-> st.write("결과:", res["generated_query"]) sql = res["generated_query"].content.split("```")[1][
3:
] # 쿼리 앞쪽의 "sql " 제거
-> sql = res["generated_query"] # 쿼리 앞쪽의 "sql " 제거
nonegom
approved these changes
Apr 21, 2025
Contributor
nonegom
left a comment
There was a problem hiding this comment.
👍 좋은 것 같습니다! 혹시 코드가 조금 길어지는 것 같으시면, 일부 코드를 모듈화 할 수도 있을 것 같습니다! sidebar의 경우 with 구문으로 사용하시는 방법도 고려해보시면 좋을 것 같아요
|
👍너무 좋습니다! |
Feature/evaluation viz
…ceLab/Lang2SQL into 10-보여주는-결과의-확장-필요성
Collaborator
|
👍 #64 에서 한번에 머지되도록 하겠습니다. @anjaaaaeeeellll님 감사합니다!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣ Issue Number
📝 요약(Summary)
💬 To Reviewers (선택)
PR Checklist
reference) How to Code Review