refactor/make-db-type-optional - db_type 파라미터를 Optional하게 받도록 수정#161
Merged
jhongy1994 merged 2 commits intoCausalInferenceLab:masterfrom Sep 29, 2025
Merged
Conversation
ehddnr301
approved these changes
Sep 23, 2025
ParkGyeongTae
approved these changes
Sep 24, 2025
| ) | ||
| st.plotly_chart(fig) | ||
| else: | ||
| st.error("SQL 원본이 문자열이 아닙니다.") |
Contributor
There was a problem hiding this comment.
💊 제 기억이 확실하지 않지만..... 리마인드 차원으로 기록만 해두겠습니다~
이 else가 필요했던 이유가 우리는 크게보면 "한국어로 질문" -> "LLM에서 쿼리를 리턴" -> "리턴받은 쿼리를 실행" 인데,
간헐적으로 질문에 따라 LLM에게 리턴받은 쿼리가.. 쿼리 형태가 아닌 경우가 있어서 이런식으로 예외처리를 했던 기억이 있습니다.
추후에 다양한 질문으로 테스트해볼텐데, 요 부분에서 자꾸 걸리는 현상이 있으면 다시 살펴보면 좋을 것 같습니다~
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣ Issue Number
📝 요약(Summary)
💬 To Reviewers (선택)
show table과show chart체크박스 모두 선택 시, 두번 반복해서 쿼리를 실행하도록 되어있어서 이를 공용으로 사용하도록 변경했습니다. 문제는 없을지 참고해주세요!PR Checklist
.env파일에서 db_type 이나 정보를 주석처리 하고 실행show table과show chart를 체크하지 않았을때, 쿼리 실행이 안되는지 확인reference) How to Code Review