Merged
Conversation
ehddnr301
requested changes
Sep 19, 2025
Collaborator
ehddnr301
left a comment
There was a problem hiding this comment.
@ParkGyeongTae 항상 코드 구조화 관련해서 좋은 제안 감사합니다!!
❗❓ 저도 리뷰를 위해 찾아보다가 발견했는데 build context 관련해서 현재 build context가 docker 경로 보다 상위 경로여서 .dockerignore 는 적용이 되지 않을듯 합니다. 제가 이해한 부분이 맞다면 변경 요청드립니다! (아니라면 편하게 말씀 부탁드려요!)
💊 ChatGPT에게 물어봤을떄는 Dockerfile.dockerignore 를 쓰라고 말해주고 있습니다
Contributor
Author
|
@ehddnr301 리뷰 감사합니다! 수정했습니다~! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣ Issue Number
📝 요약(Summary)
💬 To Reviewers (선택)
docker compose up -dPR Checklist
reference) How to Code Review