refactor: _get_column_info 함수 최적화#119
Merged
Conversation
Closed
529430d to
15ee69d
Compare
Contributor
|
@ehddnr301 님, 오랜만입니다~! 잘 지내시죠~ master 브랜치에서는 "테이블 정보 수집" 이후 "컬럼 정보 수집" 을 진행하는데, 이 브랜치에서는 "테이블 정보 수집" 이후 "컬럼 정보 수집" 을 진행하지 않는 것으로 확인됩니다. 제 테스트 명령어는 아래와 같습니다. # 환경 설치
conda create -n lang2sql2 python=3.12 -y \
&& conda activate lang2sql2 \
&& pip install .
# 실행
lang2sql --datahub_server http://34.125.57.80:8080 run-streamlit
# 웹에서 아무 쿼리 실행 |
Collaborator
Author
|
안녕하세요 @ParkGyeongTae 님!! 리뷰 감사합니다. 무탈하시죠?ㅎㅎ 아마도 아래 부분이 기존보다 시간이 좀 걸려서 fetcher = _get_fetcher()
urns = list(fetcher.get_urns())
urn_table_mapping = {}
for urn in urns:
table_name = fetcher.get_table_name(urn)
if table_name:
urn_table_mapping[table_name] = urn해당부분이 넘어가고 나면 저는 아래와 같이 출력되는데, 기다려도 아래와 같이 출력이 안되시는걸까요!? 제가 오늘 저녁에 추가로 살펴보겠습니다.
|
Contributor
|
@ehddnr301 앗~ 5분정도 기다리니까 실행합니다..! |
Collaborator
Author
그래도 꽤 걸리는군요...! Datahub 를 로컬에서 실행하실수있도록 최대한 빨리 준비해보겠습니다! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




#️⃣ Issue Number
📝 요약(Summary)
💬 To Reviewers (선택)
PR Checklist
reference) How to Code Review