Feature/80 add connectors and metadata#104
Merged
Conversation
- Added specific version of transformers (==4.51.2) - Added clickhouse-driver (>=0.2.9,<0.3.0) - Added numpy (<2.0)
Collaborator
|
👍 DB연결관련해서 더 지원이 확장되어 좋습니다. ❗Black 으로 formatting이 필요합니다. |
ehddnr301
approved these changes
Jun 23, 2025
Collaborator
There was a problem hiding this comment.
👍 테스트해봤습니다! 현재 쿼리 생성때 database가 명시가 안돼서 에러는 나지만 clickhouse 연결은 확인했습니다.
- 수정사항 확인해주시면 머지해도 될듯합니다! clickhouse 쿼리하는 부분이 에러가 나서 아래와 같이 수정했습니다.
result = self.client.query_dataframe(sql)
return result- pyproject.toml 파일의 내용을 requirements.txt 로 넣어두었습니다. (아직 배포관련 사항이 setup.py로 되어있어서요ㅜㅜ)
- 그외에는 conflict 해결을 위해 master branch 내용을 merge 했습니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣ Issue Number
: 일부만 Resolve!
📝 요약(Summary)
💬 To Reviewers (선택)
머지 시 주의 필요합니다.
PR Checklist
reference) How to Code Review