style: make texteditor height fit json editor and do not cause overflow#231
Open
qutluq wants to merge 1 commit intoCarlosNZ:mainfrom
Open
Conversation
Adjust the height of the text area based on the editor container's height, with padding. This will stop text editor from oveflow in json editor and moving comfirm buttons out of sight.
Owner
|
Thanks for this, I'll review it this week |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjusted the height of the text area based on the editor container's height, with padding. This will stop text editor from oveflowin in JsonEditor and moving confirm buttons out of sight.
Related Issues
Closes #230
Fixes #230
Resolves #230