Skip to content

Remove links if there are too many tasks #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AJaccP merged 3 commits into from
Jul 31, 2025
Merged

Remove links if there are too many tasks #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ed26c87
Remove links if there are too many tasks
AJaccP Jun 23, 2025
850c4d2
linting fix
AJaccP Jun 23, 2025
6121b31
remove links from biweekly reminder and filter out icebox
AJaccP Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/reminders/messages/completeTaskReportMessage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ export const completeTaskReportMessage = async ({
!hasUrgent && hasUpcoming && !hasUnassigned
? "Nothing urgent or unassigned upcoming! 🐀🥂"
: "Check out all upcoming tasks [here.](https://github.com/orgs/CarletonComputerScienceSociety/projects/18) 🐀🐀";
const urgentItemsLinkThreshold = 5;
const urgentItemsLinkBool = urgentItems.length <= urgentItemsLinkThreshold;

return {
title: "Biweekly Tasks Reminder ☀️🌱",
Expand All @@ -30,7 +32,7 @@ export const completeTaskReportMessage = async ({
{
title: "🔥 Urgent & Overdue",
items: urgentItems,
includeLinks: true,
includeLinks: urgentItemsLinkBool,
},
]
: []),
Expand Down
5 changes: 3 additions & 2 deletions src/reminders/messages/simpleTaskReportMessage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ export const simpleTaskReportMessage = async ({
!hasUrgent && !hasUnassigned
? "Nothing urgent or unassigned today! 🐀🥂"
: "Check out all upcoming tasks [here.](https://github.com/orgs/CarletonComputerScienceSociety/projects/18) 👀";

const urgentItemsLinkThreshold = 5;
const urgentItemsLinkBool = urgentItems.length <= urgentItemsLinkThreshold;
return {
title: `Daily Task Reminder ${randomEmoji}`,
message: `${baseMessage}\n\n💡 **Fun Fact**: ${randomFact}.`,
Expand All @@ -33,7 +34,7 @@ export const simpleTaskReportMessage = async ({
{
title: "🔥 Urgent & Overdue",
items: urgentItems,
includeLinks: true,
includeLinks: urgentItemsLinkBool,
},
]
: []),
Expand Down
4 changes: 2 additions & 2 deletions src/reminders/tasks/dailyTasksReminder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ export const dailyTasksReminder = async () => {
if (githubItemsResult.err) {
return githubItemsResult;
}

const nonBacklogItems = filterOutStatus(githubItemsResult.val, "Backlog");
const nonIceboxItems = filterOutStatus(githubItemsResult.val, "Icebox");
const nonBacklogItems = filterOutStatus(nonIceboxItems, "Backlog");
const unassignedItems = filterForUnassigned(nonBacklogItems);
const upcomingItems = filterUpcomingItems(nonBacklogItems);
const urgentItems = filterForUrgentItems(nonBacklogItems);
Expand Down