Desktop match menu update/cleanup#9790
Closed
MostCromulent wants to merge 8 commits intoCard-Forge:masterfrom
Closed
Desktop match menu update/cleanup#9790MostCromulent wants to merge 8 commits intoCard-Forge:masterfrom
MostCromulent wants to merge 8 commits intoCard-Forge:masterfrom
Conversation
Expose commonly-used preferences in match menus so players can toggle them mid-game without leaving the match. Display menu (new): targeting arcs, card overlay toggles, foil overlay, battlefield options (stack creatures, separate token row, counter display type). Layout menu: prompt pane section (compact prompt, spell description, hide reminder text, storm count) added during matches. Game menu: view deck list moved to top, auto-yield mode submenu, warn before emptying mana pool, escape key end turn, visual alert on priority. Consolidate stay-open checkbox/radio helpers and addPrefCheckBox into MenuUtil. Localize all menu labels. Support live compact prompt toggle via VPrompt repopulation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…nces Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Extract flat Prompt Pane section into a "Prompt Options" submenu, add a new "Log Detail Level" submenu with radio buttons for changing log verbosity mid-match, and move "Visually Alert on Receipt of Priority" from Game menu to Prompt Options. Standardize GameLogEntryType captions to Title Case. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Resolve conflicts preserving menucleanup's menu reorganization (flattened Layout menu, Prompt Options submenu, GameMenu reorder) with upstream's log verbosity system and configurable keyboard shortcuts. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
something about these disabled menu entries instead of submenu titles doesn't really convince me 🥴 |
Contributor
Author
That's fine, happy to move these submenus instead. What's your view on the Game / Layout / Display hierarchy? If you're not sold on that as well then I can just pare this back to additional preferences + making sure the menu doesn't auto-close on click and refreshes the field + the tooltips and localisation strings. Alternatively, I can just close this PR and we can revisit this once some of the other feature PRs land and the menu spacing/layout issues become a bit more serious than they are right now. Edit: Game |
# Conflicts: # forge-gui-desktop/src/main/java/forge/menus/LayoutMenu.java
- Replace disabled label headers in Display menu with proper submenus (Targeting Arcs, Card Overlays); flatten Battlefield items to top level - Move Hand Panel Options next to Prompt and Log panel submenus in Layout - Add Detail Level sub-submenu to Log Panel Options - Move Background Image above separator, add Reset Match Layout to Default - Rename panel submenus for consistency (Prompt/Log/Hand Panel Options) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have recently had several PRs which add additional in-game menu preferences (with more to come! #9751 ).
This is my attempt at a general update/cleanup of the desktop match menu to future-proof and keep things ordered.
Basic idea is to lightly re-structure the menu so it is intuitive and avoids regularly nesting submenus 3 or 4 layers deep.
Main categories:
(You can argue where certain things should go within this, but this is my first-pass attempt.)
Adds some commonly-used preferences to the in-match menu including creature stacking / tokens in seperate row / various prompt pane options. Obviously not every preference needs to be immediately accessible, but these strike me as ones people may reach for mid-match.
Updates menu code so the menu remains open when changing preferences (rather than closing after every change), and so that visual preferences cause an immediate update in the UI rather than needing to exit and start a new match.
Adds tooltips and localisation strings to some items that were previously missing them.
Very happy to receive feedback or suggestions on ways this could be done better.
Game
Layout
Display
🤖 Generated with Claude Code