Skip to content

fix: keep transcript button/back button visible when panel is open#1879

Open
ganganimaulik wants to merge 1 commit into
CapSoftware:mainfrom
ganganimaulik:fix/transcript-back-button
Open

fix: keep transcript button/back button visible when panel is open#1879
ganganimaulik wants to merge 1 commit into
CapSoftware:mainfrom
ganganimaulik:fix/transcript-back-button

Conversation

@ganganimaulik
Copy link
Copy Markdown

@ganganimaulik ganganimaulik commented Jun 1, 2026

Allows the user to close the transcript panel even if the caption track has been removed.

Reason: This ensures that when the transcript panel is open, the button remains visible (as "Back") so the user can close the panel, even if the transcript segments themselves have just been deleted.

Greptile Summary

This PR fixes a case where the transcript panel could get "stuck" open — if the caption track was removed while the transcript panel was open, the button to close it would disappear because its visibility was gated solely on hasTranscript(). The fix adds || isTranscriptOpen() so the button remains visible whenever the panel itself is open.

  • The Show guard on the transcript/back button is widened to hasTranscript() || isTranscriptOpen(), ensuring the close path is always reachable.
  • The existing onClick logic already handles both the open and closed states correctly, so no further changes are needed.

Confidence Score: 5/5

Safe to merge — the change is a one-line guard fix with no side effects on other code paths.

The fix is minimal and surgical: it widens a single reactive condition so the transcript close button stays visible when captions are removed mid-session. The button's internal click handler already correctly branches on isTranscriptOpen(), so no additional changes are needed and no existing paths are disrupted.

No files require special attention.

Important Files Changed

Filename Overview
apps/desktop/src/routes/editor/Header.tsx Single-condition guard on the transcript button expanded from hasTranscript() to `hasTranscript()

Reviews (1): Last reviewed commit: "fix: keep transcript button/back button ..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant