fix: keep transcript button/back button visible when panel is open#1879
Open
ganganimaulik wants to merge 1 commit into
Open
fix: keep transcript button/back button visible when panel is open#1879ganganimaulik wants to merge 1 commit into
ganganimaulik wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows the user to close the transcript panel even if the caption track has been removed.
Reason: This ensures that when the transcript panel is open, the button remains visible (as "Back") so the user can close the panel, even if the transcript segments themselves have just been deleted.
Greptile Summary
This PR fixes a case where the transcript panel could get "stuck" open — if the caption track was removed while the transcript panel was open, the button to close it would disappear because its visibility was gated solely on
hasTranscript(). The fix adds|| isTranscriptOpen()so the button remains visible whenever the panel itself is open.Showguard on the transcript/back button is widened tohasTranscript() || isTranscriptOpen(), ensuring the close path is always reachable.onClicklogic already handles both the open and closed states correctly, so no further changes are needed.Confidence Score: 5/5
Safe to merge — the change is a one-line guard fix with no side effects on other code paths.
The fix is minimal and surgical: it widens a single reactive condition so the transcript close button stays visible when captions are removed mid-session. The button's internal click handler already correctly branches on
isTranscriptOpen(), so no additional changes are needed and no existing paths are disrupted.No files require special attention.
Important Files Changed
hasTranscript()to `hasTranscript()Reviews (1): Last reviewed commit: "fix: keep transcript button/back button ..." | Re-trigger Greptile