Added edge tagging#29
Open
jmwright wants to merge 1 commit into
Open
Conversation
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Edge tagging is implemented and works on both the standard and imprinted/conformal paths.
You tag edges exactly the way you already tag faces (tag() on an edge selection) and they come through as 1D physical groups in the mesh:
Implementation note: unlike faces (matched by position), tagged edges are matched to their Gmsh curves geometrically (bounding box + midpoint), with the search restricted to each part's own curves. That keeps tags correct even when parts meet at coincident edges. README has a new "Edge Tagging" section and there are tests covering the part-prefixed, multi-part ~, and multi-solid cases.