Skip to content

Conversation

@cberger8
Copy link
Collaborator

Closes Issue #1543, #1544

Summary

Refactored the org update and delete endpoints in the registry org controller to use newly created updateOrgFull and deleteOrg functions in the base org repository.

Important Changes

src/controller/registry-org.controller/index.js

  • Removed body validating middleware

src/controller/registry-org.controller/registry-org.controller.js

  • Refactored updateOrg to validate request body against org schema and use new updateOrgFull function in base org repository.
  • Refactored deleteOrg to use new deleteOrg function in base org repository.

src/repositories/baseOrgRepository.js

  • Added updateOrgFull and deleteOrg functions.

Testing

Steps to manually test updated functionality, if possible

  • 1) Ensure that calling the PUT /api/registryOrg/<shortname> endpoint and providing an organization request body properly updates the org in both the registry and legacy collections.
  • 2) Ensure that calling the DELETE /api/registryOrg/<shortname> endpoint deletes the org in both the registry and legacy collections.

@david-rocca
Copy link
Collaborator

The code looks good, but I would love to see some integration tests. Please and thank you!

@david-rocca david-rocca merged commit ff89e19 into dev Nov 4, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants