Skip to content

Conversation

@hkong-mitre
Copy link
Contributor

does not close Issue 28 !!! See below

Summary

Temporarily skips failing tests so we can continue to develop more pressing search capabilities.

Note that the failing tests do not indicate failing logic or failing code, only that what the test code was expecting, is no longer in this repository. This includes tests for commit IDs, number of changes between commits, etc., and they no longer work because that infrastructure could not be migrated from the original GitLab repository.

Important Changes

.skip added to failing sections of the test code

Testing

All tests should now pass:

Steps to manually test updated functionality, if possible

  • npm test
  • npm run test:serial

Notes

  • We will keep this issue open even after approving this PR because the code changes do not resolve the problems in the tests and the tests are necessary for a basic functionality of cve-core.

@hkong-mitre hkong-mitre self-assigned this Sep 5, 2025
@hkong-mitre hkong-mitre changed the title Alleviates #28: temporarily skips failing tests in git Alleviates #28: temporarily skip failing tests in git Sep 5, 2025
@hkong-mitre hkong-mitre merged commit 22d57ad into dev Sep 9, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants