Skip to content

Test: Nominee endpoint#127

Open
jbriones1 wants to merge 63 commits intomainfrom
feat_nominee-tests
Open

Test: Nominee endpoint#127
jbriones1 wants to merge 63 commits intomainfrom
feat_nominee-tests

Conversation

@jbriones1
Copy link
Contributor

@jbriones1 jbriones1 commented Jan 2, 2026

depends on #126

  • Added basic integration tests for the Nominees endpoints
  • TODO: Once the checks for election officers is completed, create the rest of the tests for election officers

@jbriones1
chore(pyproject): update install steps and change to using uv
c8ead80
@jbriones1
fix: python version pinned to 3.11
e6f1072
@jbriones1
chore(gitignore): update gitignore with uv items
0d4ce6c
@jbriones1
chore(pyright): update pyright config to use version 3.11
b7c305f
@jbriones1
chore(format): ignore alembic migrations
c94aa06
@jbriones1
chore(format): ran the formatter over the entire project
a721e4f
@jbriones1
fix(ci): fix script to not rely on requirements.txt
df0f490
@jbriones1
fix(ci): split test and dev dependencies again, update action script
01cb9f4
@jbriones1
fix(ci): removed requirements.txt requirement
8fe4e74
@jbriones1
fix(uv): update uv.lock to current state
5ab91f4
@jbriones1
refactor(permissions): rewrote permissions to integrate admin types
f571eb3
@jbriones1
fix: type errors in officers crud
74bc701
@jbriones1
refactor(permissions): restructured most endpoints to use Depends
4873317
@jbriones1
fix(tests): whole test suite can now be run
6c880e1
@jbriones1
fix: missing awaits on permission check calls
268fd97
@jbriones1
fix(officers): tests now all work
69469e1
@jbriones1
fix: move conftest.py to only work on integrations tests
6e39610
@jbriones1
wip: add GET all registrations
3eeaebc
@jbriones1
wip(nominee): add create endpoint
150f08c
@jbriones1
wip: add GET all nominees
32a3ee0
@jbriones1
wip: add DELETE nominee_info
8492ff0
@jbriones1
fix(Elections): duplicate operation id in nominees URLs
3fa406a
@jbriones1
fix: patch to put
95ad68e
@jbriones1
fix: election tests now work
a751e67 
* refactored how the election officers are looked up
* changed the Nominee put back to a patch
* made election tests work with the new testing setup
@jbriones1
fix(tests): add missing param types
56f3585
@jbriones1
refactor: split election tests into multiple functions
f8824f7
@jbriones1
fix(tests): split admin elections tests
96ca71c
@jbriones1
fix(permissions): fixed some permission tests to be more efficient
a34a3c4
@jbriones1
refactor: update Nominee model names
e95efd9
@jbriones1
fix(elections): fix all elections tests
0f2a339
@jbriones1
refactor: change csss_email to a computed field
91941f9
@jbriones1
chore(officers): delete old types
846446c
@jbriones1
fix: remove csss_email
49a3c9b
@jbriones1
fix: check that end_date is null for current officers
68a5eba
@jbriones1
fix: tests failed after the check for current admin changed
2b44419
@jbriones1
refactor(elections): Election to ElectionDB
68758d1
@jbriones1
fix: election models now use timezone naive datetimes
a9ffd2f
@jbriones1
fix: made all timestamps timezone aware, UTC stored now
5331eb9
@jbriones1
fix(blogs): blogs are now timezone aware
12bd99f
@jbriones1
chore(tables): rename the rest of the DB tables
141a9ae
@jbriones1
chore: ruff fix unsorted imports
8f585f1
@jbriones1
refactor(nominee): update nominee models and PATCH request
1f1c8f0
@jbriones1
refactor(candidates): renamed registrations to candidates
5f3cdb6
@jbriones1
fix(alembic): registration renamed to candidates
17c0c67
@jbriones1
fix(nominee): update POST to use create model
43a0cf6
@jbriones1
fix(candidates): missed some renames
bf9fe64
@jbriones1
fix(candidates): updating a candidate with the same position failed
1a6ac99
@jbriones1
feat(nominee-tests): created base tests
3f39439
@jbriones1
fix(tests): databases now persist for an entire test module (file)
e7c9a2b
@jbriones1 jbriones1 requested a review from p-north January 2, 2026 07:01
@jbriones1 jbriones1 changed the title Feature: Nominee tests Test: Nominee endpoint Jan 2, 2026
@jbriones1 jbriones1 marked this pull request as ready for review January 3, 2026 21:25
p-north
p-north reviewed Jan 17, 2026
View reviewed changes
p-north
p-north reviewed Jan 17, 2026
View reviewed changes
p-north
p-north reviewed Jan 17, 2026
View reviewed changes
@jbriones1 jbriones1 requested a review from p-north January 25, 2026 01:03
p-north
p-north reviewed Feb 7, 2026
View reviewed changes
Copy link
Contributor

@p-north p-north left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, just been trying to balance work and other things! Hopefully its better now.

Everything looks good. Just some minor nitpicks here and there.

src/officers/models.py
Comment on lines +71 to +72
start_date: date | None = None
end_date: date | None = None
Copy link
Contributor

@p-north p-north Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-might want to validate the start_date and end_date but its not a big deal.

jbriones1
jbriones1 commented Feb 9, 2026
View reviewed changes
Copy link
Contributor Author

@jbriones1 jbriones1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed some comments

p-north
p-north approved these changes Feb 12, 2026
View reviewed changes
Copy link
Contributor

@p-north p-north left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@p-north p-north p-north approved these changes

+1 more reviewer

@scottdlai scottdlai scottdlai left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jbriones1 @scottdlai @p-north