Skip to content

Make axios be 1.16.0 or above#155

Merged
ryan-morosa merged 1 commit into
mainfrom
ryan-morosa/bb2-4852-update-axios_v2
Jun 9, 2026
Merged

Make axios be 1.16.0 or above#155
ryan-morosa merged 1 commit into
mainfrom
ryan-morosa/bb2-4852-update-axios_v2

Conversation

@ryan-morosa

@ryan-morosa ryan-morosa commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

JIRA Ticket:
BB2-4852

What Does This PR Do?
Upgrade axios to version 1.16.0 or higher.

What Should Reviewers Watch For?
If you're reviewing this PR, please check for these things in particular:

Validation

  • Pull down the branch and cd into the client directory
    • Run yarn install
    • Go back to the root of the directory and run docker-compose up -d
    • Run docker ps and get the client container docker id to put in the next command
    • Exec into running container: docker exec -it insert-docker-client-id-here /bin/bash
    • Run yarn why axios and verify that it's a higher version than 1.16.0 (it will probably be 1.17.0)
    • Navigate to localhost:3000 and ensure the auth flow still works

@ryan-morosa ryan-morosa marked this pull request as ready for review June 8, 2026 20:45
@annamontare-nava annamontare-nava self-assigned this Jun 8, 2026
@annamontare-nava annamontare-nava self-requested a review June 8, 2026 23:28
@annamontare-nava

Copy link
Copy Markdown
Contributor

For this one, I get axios 1.15.0

@sb-DarenDean

Copy link
Copy Markdown

Looks ok for me. Once engineer approves, you're good to go.

@ryan-morosa

Copy link
Copy Markdown
Contributor Author

For this one, I get axios 1.15.0

Weird, let me try again

@ryan-morosa

ryan-morosa commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

For this one, I get axios 1.15.0

Weird, let me try again

Hmm I still get axios@1.17.0. I also tried on main and I get 1.17.0.

@bwang-icf

Copy link
Copy Markdown
Contributor

I'm also able to get axios 1.17.0 from following the instructions here

@annamontare-nava

Copy link
Copy Markdown
Contributor

Seems like I was causing the build to fail by trying to use a newer version of yarn. After using yarn 1, things work here. Validation steps passed!

@annamontare-nava annamontare-nava left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ryan-morosa ryan-morosa merged commit 9b2e33f into main Jun 9, 2026
3 checks passed
@ryan-morosa ryan-morosa deleted the ryan-morosa/bb2-4852-update-axios_v2 branch June 9, 2026 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants