Make axios be 1.16.0 or above#155
Merged
Merged
Conversation
Contributor
|
For this one, I get axios 1.15.0 |
|
Looks ok for me. Once engineer approves, you're good to go. |
Contributor
Author
Weird, let me try again |
Contributor
Author
Hmm I still get axios@1.17.0. I also tried on main and I get 1.17.0. |
Contributor
|
I'm also able to get axios 1.17.0 from following the instructions here |
bwang-icf
approved these changes
Jun 9, 2026
Contributor
|
Seems like I was causing the build to fail by trying to use a newer version of yarn. After using yarn 1, things work here. Validation steps passed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA Ticket:
BB2-4852
What Does This PR Do?
Upgrade axios to version 1.16.0 or higher.
What Should Reviewers Watch For?
If you're reviewing this PR, please check for these things in particular:
Validation
docker-compose up -ddocker psand get the client container docker id to put in the next commanddocker exec -it insert-docker-client-id-here /bin/bashyarn why axiosand verify that it's a higher version than 1.16.0 (it will probably be 1.17.0)