BCDA-9772: Use arm64 platform#1312
Conversation
| # Wait for the database to be ready | ||
| docker run --rm --network bcda-app-net willwill/wait-for-it db-unit-test:5432 -t 120 | ||
| # docker run --rm --network bcda-app-net willwill/wait-for-it db-unit-test:5432 -t 120 | ||
| sleep 100 |
There was a problem hiding this comment.
These (and below) sleeps were quick hacks to get things working. The wait-for-it docker image is just a simple script that waits for a network to be ready. However it isnt able to run on arm64 architecture. Ive just replaced the time with a sleep for now. I think we could download the script into the repo and run it manually but felt a bit out of scope of this ticket.
There was a problem hiding this comment.
Nit: can we reduce the sleeps to 20s or so? The wait-for-it container would typically not wait that long on our local setups at least.
carlpartridge
dismissed stale reviews from juliareynolds-nava and bhagatparwinder
via
e87afae
| secrets: inherit | ||
|
|
||
| build_and_publish_ssas: | ||
| # uses: CMSgov/bcda-ssas-app/.github/workflows/build-and-publish.yml@main |
There was a problem hiding this comment.
comment is a dupe from the line below; can we remove?
| # Wait for the database to be ready | ||
| docker run --rm --network bcda-app-net willwill/wait-for-it db-unit-test:5432 -t 120 | ||
| # docker run --rm --network bcda-app-net willwill/wait-for-it db-unit-test:5432 -t 120 | ||
| sleep 100 |
There was a problem hiding this comment.
Nit: can we reduce the sleeps to 20s or so? The wait-for-it container would typically not wait that long on our local setups at least.
| lint: setup-tests | ||
| docker compose -f docker-compose.test.yml run \ | ||
| --rm tests golangci-lint run --timeout=$(LINT_TIMEOUT) --verbose --new-from-merge-base=main | ||
| docker compose -f docker-compose.test.yml run --rm \ |
There was a problem hiding this comment.
Nice catch on the --rm!
5 participants
🎫 Ticket
https://jira.cms.gov/browse/BCDA-9772
🛠 Changes
Move to arm64 architecture.
ℹ️ Context
Arm64 architecture is more efficient and should net ~20% savings.
🧪 Validation
Make docker bootstrap, make test, this PR CI checks. Successful full arm64 deploy: https://github.com/CMSgov/bcda-app/actions/runs/22596884750