Skip to content

Add support for HTTP Header Authentication#44

Merged
Rafiot merged 2 commits intoCIRCL:mainfrom
tweemeterjop:main
Feb 18, 2026
Merged

Add support for HTTP Header Authentication#44
Rafiot merged 2 commits intoCIRCL:mainfrom
tweemeterjop:main

Conversation

@tweemeterjop
Copy link
Contributor

Some PassiveDNS providers use a custom HTTP Header for user authentication.

This pull request adds support for specifying a custom HTTP header.

It also fixes the mapping to rrtype when the pdns provder outputs the rrtype in lowercase.

@Rafiot
Copy link
Member

Rafiot commented Feb 18, 2026

Thank you very much for the PR.

Very much a detail, but I'd find it nicer to pass a dict instead of a tuple for auth_header, is there any reason you picked a tuple?

Good catch for the rrtype.

@tweemeterjop
Copy link
Contributor Author

I assumed the auth_header is always a single header with a tuple for header name + value so a tuple is more strict than using a dict. Whats the use case of using a dict for the auth_header? You could also add the possibility to add additional custom headers in the form of a dict but then likely in another param.

@Rafiot
Copy link
Member

Rafiot commented Feb 18, 2026

Fair, it's just you're making the tuple into a dict in the update call. Let's merge it as-is, it is really not a hill I want to die on.

@Rafiot Rafiot merged commit 1fc12a0 into CIRCL:main Feb 18, 2026
5 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments