Add support for HTTP Header Authentication#44
Merged
Rafiot merged 2 commits intoCIRCL:mainfrom Feb 18, 2026
Merged
Conversation
Member
|
Thank you very much for the PR. Very much a detail, but I'd find it nicer to pass a dict instead of a tuple for Good catch for the rrtype. |
Contributor
Author
|
I assumed the |
Member
|
Fair, it's just you're making the tuple into a dict in the update call. Let's merge it as-is, it is really not a hill I want to die on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some PassiveDNS providers use a custom HTTP Header for user authentication.
This pull request adds support for specifying a custom HTTP header.
It also fixes the mapping to rrtype when the pdns provder outputs the rrtype in lowercase.