Adapt CFFI bindings for libyang v5 (soversion 5.0.0+)#169
Open
precla wants to merge 1 commit intoCESNET:masterfrom
Open
Adapt CFFI bindings for libyang v5 (soversion 5.0.0+)#169precla wants to merge 1 commit intoCESNET:masterfrom
precla wants to merge 1 commit intoCESNET:masterfrom
Conversation
precla
force-pushed
the
so5
branch
2 times, most recently
from
cc425f7 to
1aa6dfb
Compare
|
thanks, I'm also interested in v5! can someone review the changes? @rjarry @choppsv1 @jeremie6wind @samuel-gauthier |
|
Ping? Anyone here, any help needed? |
Author
|
the activity is low in this repo, so i guess it will take some time until someone responds |
Collaborator
|
Sorry for the delay, we will have a look before the end of May. Thanks for your work, much appreciated. |
Adapt CFFI bindings for libyang v5 (soversion 5.0.0+) Update cdefs.h, source.c, and Python call sites to match the libyang 4.2.2 -> 5.0.0 API changes: - parent field type changed from lyd_node_inner* to lyd_node* across all node structs - lyd_any_value_str gained a LYD_FORMAT parameter - lys_find_child signature was reworked - lyd_node_any lost the union lyd_any_value/LYD_ANYDATA_VALUETYPE fields - LYD_NEW_VAL_BIN / LYS_GETNEXT_WITHSCHEMAMOUNT removed tests: fix failures caused by libyang v5 changes Add missing ietf-inet-types YANG module to the test search path, as libyang v5 no longer resolves it automatically. Update the module data callback test to handle the ietf-inet-types dependency, and adjust expected error paths to match libyang v5 output. Signed-off-by: Antonio Prcela <antonio.prcela@gmail.com>
Author
|
done thanks for the update on when it will be reviewed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update cdefs.h, source.c and Python call sites to match the libyang 4.2.2 -> 5.0.0 API changes:
lyd_node_inner*tolyd_node*across all node structslyd_any_value_strgained aLYD_FORMATparameterlys_find_childsignature was reworkedlyd_node_anylost the unionlyd_any_value/LYD_ANYDATA_VALUETYPEfieldsLYD_NEW_VAL_BINandLYS_GETNEXT_WITHSCHEMAMOUNTwhich are not exiting anymore in libyang