Keep private key format as supplied by the user #572
Merged
+248
−72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, whenever a privkey was loaded from a file, its format was always changed to the SubjectPrivateKeyInfo format. With this change, the privkeys retain their format from the input file in YANG. Doesn't work for X509 privkeys when using MbedTLS.
Roytak
force-pushed
the
privkey-format-fix
branch
from
1b53d48 to
cc2efb4
Compare
michalvasko
requested changes
Jan 5, 2026
Roytak
force-pushed
the
privkey-format-fix
branch
from
cc2efb4 to
80ae943
Compare
michalvasko
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, whenever a privkey was loaded from a file, its format was always changed to the SubjectPrivateKeyInfo format. With this change, the privkeys retain their format from the input file in YANG. Doesn't work for X509 privkeys when using MbedTLS (not supported).