fix: Show user-friendly messages for GCP resource exhaustion errors #961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfsmp3
requested review from
canihavesomecoffee and
thealphadollar
as code owners
canihavesomecoffee
previously approved these changes
Dec 24, 2025
Contributor
Author
|
Good point! I've updated the code to:
For unknown error codes, sensitive info like project names and zone names are now only visible in the server logs, not exposed to users. Known error codes (ZONE_RESOURCE_POOL_EXHAUSTED, QUOTA_EXCEEDED, etc.) still return their user-friendly messages since those don't contain sensitive data. Also added tests to verify that sensitive info is logged but not returned. |
canihavesomecoffee
approved these changes
Dec 24, 2025
Fixes #901 When GCP fails to create a VM (e.g., due to zone resource exhaustion), the error was logged but the test status showed a raw error dict that was not user-friendly. Changes: - Added parse_gcp_error() helper function to extract meaningful messages from GCP API error responses - Added GCP_ERROR_MESSAGES dict mapping known error codes to user-friendly messages (ZONE_RESOURCE_POOL_EXHAUSTED, QUOTA_EXCEEDED, TIMEOUT, etc.) - Updated start_test() to use parse_gcp_error() when VM creation fails - For unknown errors, shows the error code and a truncated message Now users see messages like: "GCP resources temporarily unavailable in the configured zone. The test will be retried automatically when resources become available." Instead of raw dicts like: "{'errors': [{'code': 'ZONE_RESOURCE_POOL_EXHAUSTED', ...}]}" 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Addresses review feedback: For unknown GCP error codes, the raw error message could contain sensitive info (project names, zones, etc). Changes: - Log full error details server-side for debugging - Return generic "VM creation failed" message to users for unknown errors - Known error codes (ZONE_RESOURCE_POOL_EXHAUSTED, etc.) still return user-friendly messages - Added optional `log` parameter for testability - Updated tests to verify sensitive info is logged but not returned 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
canihavesomecoffee
force-pushed
the
fix/gcp-resource-exhaustion-901
branch
from
02a9a49 to
e7a2137
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
parse_gcp_error()helper function to extract meaningful info from GCP error responsesGCP_ERROR_MESSAGESdict mapping known error codes to clear, actionable messagesBefore
When GCP zone resources were exhausted, users saw raw error dicts like:
After
Users now see:
Known error codes handled
ZONE_RESOURCE_POOL_EXHAUSTED- Zone capacity issuesQUOTA_EXCEEDED- GCP quota limitsTIMEOUT- Operation timeoutsRESOURCE_NOT_FOUND- Missing resourcesRESOURCE_ALREADY_EXISTS- Duplicate VM namesTest plan
parse_gcp_error()covering all edge casesCloses #901
🤖 Generated with Claude Code