Skip to content

Fix potential out-of-bounds access in write_stringz_as_srt_to_output #2128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rhythmcache wants to merge 2 commits into
base: master
Choose a base branch
from
+2 −2
Open

Fix potential out-of-bounds access in write_stringz_as_srt_to_output #2128

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d85b32
Fix loop condition for reading unescaped string
rhythmcache Feb 20, 2026
adb2e70
Fix condition to check for newline escape sequence
rhythmcache Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/lib_ccx/ccx_encoders_srt.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ static int write_stringz_as_srt_to_output(char *string, struct encoder_ctx *cont
// Scan for \n in the string and replace it with a 0
while (pos_r < len)
{
if (string[pos_r] == '\\' && string[pos_r + 1] == 'n')
if (pos_r < len - 1 && string[pos_r] == '\\' && string[pos_r + 1] == 'n')
{
unescaped[pos_w] = 0;
pos_r += 2;
Expand All @@ -62,7 +62,7 @@ static int write_stringz_as_srt_to_output(char *string, struct encoder_ctx *cont
unescaped[pos_w] = 0;
// Now read the unescaped string (now several string'z and write them)
unsigned char *begin = unescaped;
while (begin < unescaped + len)
while (begin < unescaped + pos_w)
{
unsigned int u = encode_line(context, el, begin);
if (context->encoding != CCX_ENC_UNICODE)
Expand Down
Loading