fix(mp4): Use fixed-width integer types in bswap functions #1923
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
bswap16andbswap32to useint16_tandint32_tinstead ofshortandlongProblem
On Windows x64,
longis 4 bytes (LLP64 model), while on Linux x64longis 8 bytes (LP64 model). This type size difference in thebswap32function could cause inconsistent behavior when parsing NAL unit lengths in MP4/MOV files.When reading NAL lengths with
*(long *)&s->data[i]:This could potentially affect timestamp calculations and cause the timing differences observed between Windows and Linux CI tests.
Changes
bswap16shortint16_tbswap32longint32_tAll call sites in
process_avc_sample()andprocess_hevc_sample()updated accordingly.Test plan
🤖 Generated with Claude Code