Skip to content

Conversation

@tusharbhatt7
Copy link

Problem
When CCExtractor processes a .ts file that contains no subtitles, it produces infinite binary/hex-like output in the terminal instead of stopping gracefully.

Solution
Removed the dump() call in copy_capbuf_demux_data() for CCX_PRIVATE_MPEG2_CC buffer type. This dump was using CCX_DMT_GENERIC_NOTICES which is enabled by default, causing continuous binary output to the terminal.

Changes

  • Removed dump(CCX_DMT_GENERIC_NOTICES, ...) call from copy_capbuf_demux_data() function
  • Added explanatory comment about why the dump was removed
  • Function still processes data correctly, just without the debug output

Testing

  • Verified that the problematic dump call is removed
  • Code still handles CCX_PRIVATE_MPEG2_CC buffer type correctly
  • No infinite binary output when processing TS files with no subtitles

Fixes #1754

Remove dump() call in copy_capbuf_demux_data() for CCX_PRIVATE_MPEG2_CC
buffer type that was causing infinite binary/hex output to terminal when
processing TS files containing no subtitles. The dump() function used
CCX_DMT_GENERIC_NOTICES which is enabled by default.

Fixes CCExtractor#1754
@ccextractor-bot
Copy link
Collaborator

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit 000b397...:
Report Name Tests Passed
Broken 13/13
CEA-708 14/14
DVB 7/7
DVD 3/3
DVR-MS 2/2
General 24/27
Hardsubx 1/1
Hauppage 3/3
MP4 3/3
NoCC 10/10
Options 81/86
Teletext 21/21
WTV 13/13
XDS 34/34

Your PR breaks these cases:

  • ccextractor --autoprogram --out=ttxt --latin1 1974a299f0...
  • ccextractor --autoprogram --out=ttxt --latin1 --ucla dab1c1bd65...
  • ccextractor --out=srt --latin1 --autoprogram 29e5ffd34b...
  • ccextractor --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9...
  • ccextractor --startcreditsnotbefore 1 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9...
  • ccextractor --startcreditsnotafter 2 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9...
  • ccextractor --startcreditsforatleast 1 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9...
  • ccextractor --startcreditsforatmost 2 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9...

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Check the result page for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Infinite binary output when processing .ts files with no subtitles

2 participants