Fix infinite binary output when processing .ts files with no subtitles #1891
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When CCExtractor processes a .ts file that contains no subtitles, it produces infinite binary/hex-like output in the terminal instead of stopping gracefully.
Solution
Removed the
dump()call incopy_capbuf_demux_data()forCCX_PRIVATE_MPEG2_CCbuffer type. This dump was usingCCX_DMT_GENERIC_NOTICESwhich is enabled by default, causing continuous binary output to the terminal.Changes
dump(CCX_DMT_GENERIC_NOTICES, ...)call fromcopy_capbuf_demux_data()functionTesting
CCX_PRIVATE_MPEG2_CCbuffer type correctlyFixes #1754