Skip to content

fix: prevent infinite loop when processing TS files with no subtitles #1763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DhanushVarma-2 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: prevent infinite loop when processing TS files with no subtitles #1763

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d4d84b
fix: prevent infinite loop when TS files have no subtitle streams
invalid-email-address Dec 17, 2025
926293c
style: apply clang-format to ts_functions.c
invalid-email-address Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions src/lib_ccx/ts_functions.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -748,6 +748,8 @@ long ts_readstream(struct ccx_demuxer *ctx, struct demuxer_data **data)
struct cap_info *cinfo;
struct ts_payload payload;
int j;
int all_pmts_analyzed = 0; // Track if all programs have analyzed their PMT
int packets_after_pmt_analysis = 0;
static int no_pat_warning_shown = 0;

memset(&payload, 0, sizeof(payload));
Expand All @@ -756,6 +758,31 @@ long ts_readstream(struct ccx_demuxer *ctx, struct demuxer_data **data)
{
pcount++;

// Check if all PMTs have been analyzed
if (!all_pmts_analyzed)
{
all_pmts_analyzed = 1;
for (j = 0; j < ctx->nb_program; j++)
{
if (ctx->pinfo[j].analysed_PMT_once == CCX_FALSE)
{
all_pmts_analyzed = 0;
break;
}
}
}

// After all PMTs analyzed, if no caption streams found after reasonable packets, exit
if (all_pmts_analyzed)
{
packets_after_pmt_analysis++;
if (packets_after_pmt_analysis > 1000 && ctx->num_of_PIDs == 0)
{
dbg_print(CCX_DMT_PARSE, "\nNo caption/subtitle streams found in any PMT after %ld packets. This file contains no extractable subtitles.\n", pcount);
return CCX_EOF;
}
}

// Exit the loop at EOF
ret = ts_readpacket(ctx, &payload);
if (ret != CCX_OK)
Expand Down
Loading