Skip to content

Conversation

@steel-bucket
Copy link
Contributor

@steel-bucket steel-bucket commented Jul 13, 2025

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

Added MXF module, ccx_demuxer_mxf.c and ccx_demuxer_mxf.h
Tested on This sample and successfully extracting subtitles.
Screenshot from 2025-06-30 23-29-44
Screenshot from 2025-06-30 23-29-39
Dependant on #1662 and #1711
PR Moved from My Fork to Here.

@steel-bucket steel-bucket changed the title [Rust] Added module [Rust] Added MXF module Jul 13, 2025
@steel-bucket steel-bucket mentioned this pull request Jul 13, 2025
10 tasks
@ccextractor-bot
Copy link
Collaborator

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit 099fa05...:
Report Name Tests Passed
Broken 12/13
CEA-708 13/14
DVB 6/7
DVD 0/3
DVR-MS 2/2
General 22/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Options 81/86
Teletext 21/21
WTV 13/13
XDS 32/34

NOTE: The following tests have been failing on the master branch as well as the PR:

Congratulations: Merging this PR would fix the following tests:


All tests passing on the master branch were passed completely.

Check the result page for more info.

@ccextractor-bot
Copy link
Collaborator

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit 81fdecd...:
Report Name Tests Passed
Broken 11/13
CEA-708 13/14
DVB 2/7
DVD 0/3
DVR-MS 2/2
General 17/27
Hauppage 1/3
MP4 3/3
NoCC 10/10
Options 78/86
Teletext 4/21
WTV 10/13
XDS 30/34

NOTE: The following tests have been failing on the master branch as well as the PR:

Congratulations: Merging this PR would fix the following tests:


All tests passing on the master branch were passed completely.

Check the result page for more info.

Copy link
Contributor

@cfsmp3 cfsmp3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the MXF module migration! The code looks well-structured and all CI builds pass including test_rust.

However, this PR is blocked by #1711 (GXF module) which has significant issues:

  • ~40 Linux test failures including crashes (exit code 139)
  • ~30 Windows test failures including crashes (ACCESS_VIOLATION)
  • Unresolved review comments from @prateekmedia

The sample platform test failures in this PR are likely inherited from #1711 since the GXF module is a dependency.

Next steps:

  1. Please work on fixing #1711 first (address the crashes and review comments)
  2. Once #1711 is merged, rebase this PR on master
  3. Re-run sample platform tests to verify MXF functionality

The MXF-specific code and your testing look good. I appreciate the screenshots showing successful subtitle extraction!


Marking as reviewed - this PR is blocked by dependency, not by its own issues.

@cfsmp3 cfsmp3 mentioned this pull request Dec 17, 2025
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants