2021.01.19 #45
Open
2021.01.19 #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TakumaKurosawa
approved these changes
Jan 20, 2021
|
|
||
| ## うまくいったこと | ||
|
|
||
| - とりあえず、仕様書の機能をみたすガチャできました！ |
Comment on lines
+15
to
+18
| - 分かりやすくなるようコードを切り分けるというのがなかなか難しいです、、、 | ||
| → 今日説明していただいて、言われると確かに現状のコードはすごく分かりにくいなと思うものの、 | ||
| 実際に分かりやすい切り分けを考えるとなると難しかったです。 | ||
| → まずはリーダブルコードやpospomeさんの書籍を読んで、勉強したいと思います！ |
Contributor
There was a problem hiding this comment.
アプリケーションアーキテクチャの話はすごく高度な話だと思うので，これからPospomeさんの書籍とか通して勉強していこう！
y-kishida
approved these changes
Jan 24, 2021
kznrluk
approved these changes
Feb 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue44
close #44
補足事項