Skip to content

Conversation

@poespas
Copy link
Collaborator

@poespas poespas commented Dec 17, 2024

Rather have too much than too little, right?

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

new PlatformConfiguration\HypernodeSettingConfiguration('nodejs_version', '20'),
]);

$configuration->addBuildTask('node:env');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm missing the registration of the node:env task here. Or is it a builtin of Deployer?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, removed that last-minute as most configurations wouldn't need it because of shared files, will be removing this line.

@github-actions
Copy link
Contributor

@tdgroot
Copy link
Member

tdgroot commented Dec 20, 2024

@poespas can you fix the formatting for the document? Then we can merge :)

@github-actions
Copy link
Contributor

@poespas poespas merged commit c8210ee into master Dec 20, 2024
8 checks passed
@poespas poespas deleted the add_sample_nextjs_example_hypernode_deploy branch December 20, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants