new build system - tsup
#13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophP
reviewed
Apr 28, 2025
package.json
Outdated
| "require": "./dist/index.cjs", | ||
| "import": "./dist/index.js", | ||
| "default": "./dist/index.js", | ||
| "types": "./dist/index.d.ts" |
Collaborator
There was a problem hiding this comment.
I read once that exports are checked in order. default always matches so it needs to go last. Otherwise types will never be matched.
ChristophP
reviewed
Apr 28, 2025
| "scripts": { | ||
| "build": "npm run clean && tsc --build tsconfig.build.esm.json && tsc --build tsconfig.build.cjs.json && tsc --build tsconfig.build.umd.json", | ||
| "clean": "rm -rf dist", | ||
| "build": "tsup src/index.ts --format cjs,esm --dts --minify --clean", |
Collaborator
There was a problem hiding this comment.
With tsc not being used anymore maybe you wanna add an extra script for typechecking and add it to the pipline. Like npm run type-check which does tsc --noEmit.
Tsup does not do any typechecks, just transpiling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new build system -
tsup