New Explore cmd + maintainence#88
Open
Zoriot wants to merge 17 commits into
Open
Conversation
Zoriot
added
🚨 high priority
…anch name, and git hash
Not sure how this was even made.
Now we have reproducible build's again. Dependencies were also updated + reordered. Via https://github.com/littlerobots/version-catalog-update-plugin.
- Create CitySelectorMenu for selecting cities within states - Refactor StateSelectorMenu to dynamically detect states and sub-cities - Update CountrySelectorMenu to open state selector for USA - Use Hardcoded Logic for NYC City This enables navigation flow: USA → States → Cities (e.g., NY → NYC) & USA -> States -> New Jersey.
Make warp creation, editing, and deletion instantly responsive by: - Updating local state immediately before API calls - Sending success messages without waiting for network - Processing API calls and cache updates asynchronously - Rolling back local changes if API calls fail This eliminates the multi-second delay users experienced when creating or editing warps, as operations no longer block on: 1. Network API request completion 2. Full cache refresh from API 3. BlueMap marker updates Closes #89.
Zoriot
added
🐻 medium size
Qodana for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
Fix NoSuchElementException when creating warps at coordinates with no location data (ocean/unmapped areas). Menu now reopens after errors so players can retry from a different location. Fixes #58.
- Add @nonnull annotations to method parameters overriding @NotNull - Add null checks and Objects.requireNonNull() for potentially null returns - Replace printStackTrace() with proper ComponentLogger.error() calls - Remove unused imports across multiple files - Convert field constants to local variables where appropriate - Add @SuppressWarnings for unavoidable unchecked warnings - Fix stream API calls (collect(toList()) → toList()) - Replace size comparisons with isEmpty() - Fix non-regex replaceAll() to use replace() - Use parameterized logging to avoid string concatenation Fixes 125+ code quality issues identified in Qodana report while maintaining all functionality. The main remaining issues are Message / Component related which will be fixed once we add translation. Hopefully very soon. Now we don't set a baseline anymore for better reporting.
Implements #42. At least the light version of it.
This fixes parsing of other coordinate format's like the Simplex (BTE Israel) format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regions are now also use the continent from the region itself and not from the build team, now most are in the correct part in the menu. Now the Listeners for the navigator item are only registered if it's enabled in the config, so it will not clash with other plugins + saves resources.
This includes also important dependency Updates: