Skip to content

๐Ÿœ Study: ํ˜ธํ…” ๋ฐฉ ๋ฐฐ์ •#84

Merged
ing-eoking merged 1 commit intoBugShelter:mainfrom
ing-eoking:04/15
Apr 17, 2025
Merged

๐Ÿœ Study: ํ˜ธํ…” ๋ฐฉ ๋ฐฐ์ •#84
ing-eoking merged 1 commit intoBugShelter:mainfrom
ing-eoking:04/15

Conversation

@ing-eoking
Copy link
Collaborator

๐Ÿ“Œ ๊ด€๋ จ ๋ฌธ์ œ

๐Ÿ“‹ ํ’€์ด ์š”์•ฝ

upper bound ๋ฌธ์ œ

๐Ÿ˜ž ์‹คํŒจํ•œ ํ…Œ์ŠคํŠธ ์ผ€์ด์Šค

@ing-eoking ing-eoking requested a review from Copilot April 15, 2025 07:32
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

ํ˜ธํ…” ๋ฐฉ ๋ฐฐ์ •.cc:11

  • The use of magic numbers (e.g., -1 and k+2) for sentinel values reduces code clarity; consider defining named constants to explicitly represent these boundary values.
m[-1] = -1;

ํ˜ธํ…” ๋ฐฉ ๋ฐฐ์ •.cc:14

  • [nitpick] The variable name 'piv' (and consequently 'aft') is unclear; renaming them to more descriptive identifiers (such as 'prev_it' and 'next_it') would improve readability.
auto piv = m.upper_bound(num);

@ing-eoking ing-eoking merged commit 9320a55 into BugShelter:main Apr 17, 2025
@ing-eoking ing-eoking deleted the 04/15 branch April 17, 2025 00:44
@ing-eoking ing-eoking self-assigned this Apr 17, 2025
@ing-eoking ing-eoking added Algorithm ์•Œ๊ณ ๋ฆฌ์ฆ˜ ๋ฌธ์ œ ํ’€์ด ๐Ÿœ Study ์•Œ๊ณ ๋ฆฌ์ฆ˜ ๋ฌธ์ œ ๊ณต๋ถ€ labels Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Algorithm ์•Œ๊ณ ๋ฆฌ์ฆ˜ ๋ฌธ์ œ ํ’€์ด ๐Ÿœ Study ์•Œ๊ณ ๋ฆฌ์ฆ˜ ๋ฌธ์ œ ๊ณต๋ถ€

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[์˜ค๋Š˜์˜ ์•Œ๊ณ ๋ฆฌ์ฆ˜] ํ˜ธํ…” ๋ฐฉ ๋ฐฐ์ •

2 participants