๐ Study: ํธํ ๋ฐฉ ๋ฐฐ์ #84
Merged
ing-eoking merged 1 commit intoBugShelter:mainfrom Apr 17, 2025
Merged
Conversation
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
ํธํ ๋ฐฉ ๋ฐฐ์ .cc:11
- The use of magic numbers (e.g., -1 and k+2) for sentinel values reduces code clarity; consider defining named constants to explicitly represent these boundary values.
m[-1] = -1;
ํธํ ๋ฐฉ ๋ฐฐ์ .cc:14
- [nitpick] The variable name 'piv' (and consequently 'aft') is unclear; renaming them to more descriptive identifiers (such as 'prev_it' and 'next_it') would improve readability.
auto piv = m.upper_bound(num);
ing-eoking
added a commit
that referenced
this pull request
Apr 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
๐ ๊ด๋ จ ๋ฌธ์
๐ ํ์ด ์์ฝ
upper bound ๋ฌธ์
๐ ์คํจํ ํ ์คํธ ์ผ์ด์ค