Merged
Conversation
Closed
ing-eoking
reviewed
Apr 1, 2025
yongjun-0903/구명보트.py
Outdated
There was a problem hiding this comment.
The condition 'len(boat) <= 2' could allow more than two persons per boat. If the boat's capacity is two, consider changing this to 'len(boat) < 2' to enforce the correct limit.
Suggested change
| if sum(boat) + person <= limit and len(boat) <= 2: | |
| if sum(boat) + person <= limit and len(boat) < 2: |
yongjun-0903/구명보트.py
Outdated
There was a problem hiding this comment.
In the else branch, the current person is skipped and not reprocessed, which may result in an undercount of boats. Consider re-adding the current person back to the queue or re-evaluating without discarding this person.
Suggested change
| else: | |
| else: | |
| queue.appendleft(person) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 관련 문제
📋 풀이 요약
😞 실패한 테스트 케이스