Skip to content

app-upload flow fix #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samirans89 merged 1 commit into from
Dec 9, 2025
Merged

app-upload flow fix #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions mac/common-utils.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,13 +102,19 @@ handle_app_upload() {
case $opt in
"Use Sample App") choice="Use Sample App"; break ;;
"Upload my App (.apk/.ipa)") choice="Upload my App"; break ;;
"Cancel") choice="Cancel"; break ;;
*) echo "Invalid option";;
"Cancel") choice="Cancel";
log_error "App upload cancelled by user."; exit 1;;
*)
log_error "App upload cancelled by user."; exit 1;;

esac
done
fi

if [[ "$choice" == *"Use Sample App"* ]]; then

if [[ "$choice" == "" ]]; then
log_error "App upload cancelled by user."
exit 1
elif [[ "$choice" == *"Use Sample App"* ]]; then
upload_sample_app
app_platform="android"
export APP_PLATFORM="$app_platform"
Expand Down Expand Up @@ -165,7 +171,8 @@ upload_custom_app() {

if [ -z "$file_path" ]; then
log_msg_to "❌ No file selected"
return 1
log_error "App upload cancelled by user. No .apk /.ipa file path provided."
exit 1
fi

log_info "Selected file: $file_path"
Expand Down
2 changes: 1 addition & 1 deletion mac/env-setup-run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ setup_environment() {
max_parallels=$TEAM_PARALLELS_MAX_ALLOWED_MOBILE
fi

log_msg_to "Starting ${setup_type} setup for " "$tech_stack" "$NOW_RUN_LOG_FILE"
log_msg_to "Starting ${setup_type} setup for $tech_stack" "$NOW_RUN_LOG_FILE"

local local_flag=false

Expand Down
Loading