Open
Conversation
BreakBB
reviewed
Mar 2, 2026
Owner
BreakBB
left a comment
BreakBB
left a comment
There was a problem hiding this comment.
What exactly is the goal of this PR? Just want to make sure I understand what you are trying to achieve.
Modules/Data/Constants.lua
Outdated
Comment on lines
244
to
249
| [19742] = (IsClassic and nil or 1), -- Blessing of Wisdom rank 1 | ||
| [19850] = (IsClassic and nil or 1), -- Blessing of Wisdom rank 2 | ||
| [19852] = (IsClassic and nil or 1), -- Blessing of Wisdom rank 3 | ||
| [19853] = (IsClassic and nil or 1), -- Blessing of Wisdom rank 4 | ||
| [19854] = (IsClassic and nil or 1), -- Blessing of Wisdom rank 5 | ||
| [25290] = (IsClassic and nil or 1), -- Blessing of Wisdom rank 6 |
Owner
There was a problem hiding this comment.
This does not work. You can't do and nil or because it will always be the or case.
That's why I changed it here as a fix last time it was broken. It needs to be and X or nil.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm testing it. For now no issues.